Fix test.sh by using the supplied command in docker-entrypoint.sh #80
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker uses a 2-part separation between the
ENTRYPOINT
command (which is what's always run indocker run
) and theCMD
command (which is provided as arguments to theENTRYPOINT
script). Right now,test.sh
doesn't work because it's attempting to overrideCMD
, butdocker-entrypoint.sh
is ignoringCMD
in favor of a hardcoded call to/usr/sbin/vsftpd
.The fix for this is really easy, as you can see by the patch size! Specify what we were already doing as the
CMD
and havedocker-entrypoint.sh
call it. This means when you overrideCMD
liketest.sh
does,docker-entrypoint.sh
respects what you ask for.